Check host_maps and host_data in the GPU transformations #1701
+140
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
approved these changes
Oct 24, 2024
Co-authored-by: Tal Ben-Nun <[email protected]>
alexnick83
reviewed
Oct 25, 2024
| def _output_or_input_is_marked_host(self, state, entry_node): | ||
| if (self.host_data is None or self.host_data == []) and (self.host_maps is None or self.host_maps == []): | ||
| return False | ||
| marked_accesses = [e.data.data for e in state.in_edges(entry_node) + state.out_edges(state.exit_node(entry_node)) |
There was a problem hiding this comment.
Wouldn't checking memlet paths and adding the src and destination data make more sense here?
There was a problem hiding this comment.
To clarify, I am considering issues similar to those identified in #1708
| for state in sdfg.nodes(): | ||
| for node in state.nodes(): | ||
| if isinstance(node, nodes.EntryNode) and node.guid in self.host_maps: | ||
| accesses = {e.data.data for e in state.in_edges(node) + state.out_edges(state.exit_node(node)) |
| @@ -312,11 +338,13 @@ def apply(self, _, sdfg: sd.SDFG): | |||
| for node in state.nodes(): | |||
| if sdict[node] is None: | |||
| if isinstance(node, (nodes.LibraryNode, nodes.NestedSDFG)): | |||
| node.schedule = dtypes.ScheduleType.GPU_Default | |||
| gpu_nodes.add((state, node)) | |||
| if node.guid not in self.host_maps and not self._output_or_input_is_marked_host(state, node): | |||
There was a problem hiding this comment.
If the node is a LibraryNode or NestedSDFG, why would its ID be in host_maps? A documentation line clarifying that host_maps can also be used for the above SDFG elements suffices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.